-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Jenkins plugin standards #3
Conversation
Signed-off-by: Alexander Brandes <mc.cache@web.de>
9dc7cc1
to
738c91b
Compare
src/main/java/com/mathworks/polyspace/jenkins/utils/PolyspaceHelpersUtils.java
Show resolved
Hide resolved
Thanks Alex for your help! Very much appreciated! |
Hi Alex! I have got some questions about your config changes I just merged. The following action ran fine on the JenkinsCI account for my plugin: https://github.com/jenkinsci/mathworks-polyspace-plugin/actions/runs/8246795872 I don't have a clear understanding on how it works but I can see the same action has run on the Mathworks account for my plugin (main repo) and I receveid an email notification. But it failed: https://github.com/mathworks/mathworks-polyspace-plugin/actions/runs/8246811591 Note that I tried to rerun the job. But it still fails. What should I do with it? Should I care? Should I fix? How should I fix? Moreover, I have tried to deploy a new version of my plugin by running "mvn -e -X release:prepare release:perform" and it failed as well (log attached). Is it related with the config changes your proposed? How can I fix? Thanks! Stephane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The change proposed applies the standards for Jenkins plugins and helps to diagnose build and release issues, given the plugin doesn't build on ci.jenkins.io at all at the moment.
I've seen your post on the mailing list and decided to file a quick PR with a small QoL improvement towards the plugin :)